[SailfishDevel] Add locale support to jolla calendar
Carsten Munk
carsten.munk at jolla.com
Fri Nov 14 08:01:27 UTC 2014
On 13/11/14 22:43, E.S. Rosenberg wrote:
> Well I solved it and now it's dependent on the locale (which by
> default is not set on Jolla) so:
>
> 1. I am more then happy to submit my patches to Jolla, though you guys
> claim 'closed source' every file I edited had a BSD license at the top.
rpm -qf /path/to/file
to check what package it is in, should make it easier to figure out if
it's in the open MW/Core or closed source.
/Carsten
>
> 2. To actually make this work properly jolla one or all of the
> following environment variables need to be present LC_TIME, LC_ALL,
> LANG, by default LANG is present but for people like me who want
> language A but locale B for dates etc. so some way to set LC_* or at
> least LC_ALL would be cool.
> I tried adding to my .bashrc but that had no effect for launching from
> the launcher, from CLI it helpend of course.
> I assume I need to add it somewhere in dconf but I'm not knowledgeable
> enough about dconf for the moment...
>
> 3. The only issue I saw that may need a special exception is february
> where adding an extra week before may look nicer, but this is an
> aesthetics issue and as far as I can tell from the widget in gnome
> they don't mind having 2 weeks of the next month showing...
>
> I tested it with locales: en_GB (monday), nl_NL (monday), he_IL
> (sunday), ar_KW (saturday).
>
> Should I publish the patches here or is that considered unacceptable
> behavior on this list?
> I will probably try to put everything up neatly on my github later...
> (ie full files..)
>
> Regards,
> Eli
>
> 2014-11-13 19:13 GMT+02:00 E.S. Rosenberg
> <es.rosenberg+sailfishos.org at gmail.com
> <mailto:es.rosenberg+sailfishos.org at gmail.com>>:
>
>
>
> 2014-11-13 14:25 GMT+02:00 Pekka Vuorela <pekka.vuorela at jolla.com
> <mailto:pekka.vuorela at jolla.com>>:
>
> to, 2014-11-13 kello 02:25 +0200, E.S. Rosenberg kirjoitti:
> > Hi all,
> >
> > I'm trying to add support for locale (or at least
> firstDayOfWeek) to
> > jolla-calendar, in the MonthPage.qml file I successfully
> made the day
> > labels depend on the locale, but to actually shift all the
> dates over
> > seems to be more of an issue.
> >
> >
> > As far as I can tell this should involve the AgendaModel
> (found in
> > nemomobile/nemo-qml-plugin-calendar), but I may be wrong.
> >
> >
> > Either way I have 2 questions:
> >
> > 1. Am I on the right track?
>
> AgendaModel returns events between start and end dates. It
> does not care
> about localization details or where a week starts from.
>
> > 2. Assuming I pull this off successfully what is the process for
> > submitting the patch? A pull request on git? sending a patch
> to this
> > list?
>
> For changes in nemo-qml-plugin-calendar, a pull request in github.
> Jolla-calendar itself is not open so we don't take patches.
> However,
> there are some patches around people have been applying
> themselves.
>
> Well it would be cool of Jolla released the source of
> jolla-calendar so we can fix these things, it seems the calendar
> is anyhow not getting that much attention...
>
>
> Support for sunday as first day of week should go to
> DatePicker&...Dialog. To be done at some point.
>
> Is this defined in compiled code or in QML... I'll happily fix it
> and donate the code :)
> At the moment I for the life of me can't figure out where it is
> getting the actual start and end dates of the displayed calendar
> days...
>
> Not much votes yet on these, though:
> https://together.jolla.com/question/26507/ability-to-set-firstdayofweek-in-jolla-calendar/
>
>
> I can't vote on my own questions... :D
> If jolla intends to come to Israel at some point this needs to be
> fixed though...
> Thanks,
> Eli
>
> https://together.jolla.com/question/35138/can-i-change-the-first-day-of-week-in-calendar/
>
>
> _______________________________________________
> SailfishOS.org Devel mailing list
> To unsubscribe, please send a mail to
> devel-unsubscribe at lists.sailfishos.org
> <mailto:devel-unsubscribe at lists.sailfishos.org>
>
>
>
>
>
> _______________________________________________
> SailfishOS.org Devel mailing list
> To unsubscribe, please send a mail to devel-unsubscribe at lists.sailfishos.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.sailfishos.org/pipermail/devel/attachments/20141114/a6fe03ba/attachment.html>
More information about the Devel
mailing list