[SailfishDevel] Harbour validation rules for SFOS 3.3

[Lukáš Karas]

Hi. 

I updated my application OSM Scout yesterday and it was rejected to Harbout, 
because it contains "hardcoded paths". Even check in SDK fails, so I may 
reproduce it (http://localhost:8080/C/harbour_tools/). But the reason seems to 
be weird to me. 

For example recent export path in SVG file that is added by Inkscape:

>  ERROR [/usr/share/harbour-osmscout/map-icons/bus_stop.svg] Hardcoded path: 
inkscape:export-filename="/home/tim/projects/OSMScout/libosmscout/data/icons/
14x14/standard/bus_stop.png"

Do you really want to check hard-coded paths in SVG files? It is easy to 
remove it, but I would need to do it after every modification... 


Another "errors" comes from application binary itself, for example:

> ERROR [/usr/bin/harbour-osmscout] Hardcoded path: /home/mersdk/share/
SailfishOS/projects/osmscout-sailfish/src/AppSettings.cpp

It seems that validation script is grep-ing output from strings command...
When I am looking to source code, it seems that these strings are keep in 
binary because of GCC assert macro. I definitely want to use asserts in my 
production builds. To comply this validation, I would need to introduce own 
assert, that will not use __FILE__ macro for messages... It sounds weird to 
me.

Both cases looks like false positive to me. Or there is any real reason to 
rejecting such binaries?

Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.sailfishos.org/pipermail/devel/attachments/20200512/11f28af1/attachment.sig>